Commit Graph

748 Commits

Author SHA1 Message Date
Simon Wydooghe 2febdfc363
Fix: allow removal of email address as contact
It seems the current code doesn't allow for removing the email address
from the contact field. This fixes that. This only removes the email
address if an explicit empty email address is specified on the command
line or in the account.conf file. If it is left unspecified on the
command line it still just uses whatever was configured in the
account.conf.
2020-04-17 15:53:15 +02:00
neil 93de1e4903 un-escape json chars
fix https://github.com/acmesh-official/acme.sh/issues/2833
2020-04-12 11:48:24 +08:00
Oliver Burgmaier 7595808d26 fix #2828 mailto compliant to RFC6068
This fix removes the space between "mailto:" and the email address to
make the contact attribute compliant to RFC6068.
2020-04-01 20:35:07 +02:00
Oliver Burgmaier 37d22a144a fix #2830 Autorization segment typo fixed
This fixes the parsing of the authorization segment in the response of
an order. Without this fix the start of the array is not found
correctly and therefore the finalize URL is part of the authorization
segment. Changing the regex to *\[[^\[]*\] fix this. Seems to be a typo
which has not been recognized so far. This can be only recognized if
the response is in a single line.
2020-04-01 20:31:06 +02:00
Oliver Burgmaier dc697a6862 fix #2830 Autorization segment typo fixed
This fixes the parsing of the authorization segment in the response of
an order. Without this fix the start of the array is not found
correctly and therefore the finalize URL is part of the authorization
segment. Changing the regex to *\[[^\[]*\] fix this. Seems to be a typo
which has not been recognized so far. This can be only recognized if
the response is in a single line.
2020-04-01 20:24:40 +02:00
Xiaohui Lam ff9be30f86
resolved #2818 2020-03-31 03:10:12 +08:00
Oliver Blaha cb7e38577d add support for upgrade from tag 2020-03-24 14:44:35 +01:00
neil 3d81641139 fix format 2020-03-09 19:04:32 +08:00
neil 0f24417cb3
Merge pull request #2769 from ianw/update-account-json
Update account.json on account update
2020-03-07 19:50:17 +08:00
neil f84a87f2a2 remove DEFAULT_DNS_SLEEP.
fix https://github.com/acmesh-official/acme.sh/issues/2773
2020-03-07 18:26:22 +08:00
Ian Wienand 72e1a1b2e9 Update account.json on account update
When running --updateaccount, the ca/<ca>/account.json file isn't
updated with the new response showing the updated account details.
This can be a bit confusing if you add an email to the account but
then you're not sure if it actually applied looking at this file.

Write out the new response on successful account updates.
2020-03-04 12:28:21 +11:00
alex 22f9a3b467 Fix error on docker deploy command with spaces.
This adds quotes to the last eval in _getdeployconf which is reponsible
for loading and exporting saved environment variables back into the
acme.sh process. This caused some errors if used with the docker
deploy-hook and the example nginx "service nginx force-reload" command
as it contains spaces.
2020-02-25 12:37:46 +01:00
xpac1985 463df9e4ba
Make socat debug output show version + features instead of help text 2020-02-18 16:26:15 +01:00
neil 490fbfc13e
Merge pull request #2701 from xpac1985/patch-1
Updated/fixed some entries in --help output
2020-01-31 16:32:13 +08:00
neilpang 09f74a9af8 start v2.8.6, change the repo name 2020-01-30 10:50:39 +08:00
neilpang f8b225e70e fix format 2020-01-27 23:30:36 +08:00
neilpang fc3a181779 move the error message 2020-01-27 23:07:10 +08:00
neilpang 9541ea6a9f fix bug https://github.com/Neilpang/acme.sh/issues/2695
If a domain was already verified by http-01 method,  when we try to issue a cert for them same domain with dns-01 method, we just get only one challenge object of type http-01 with "valid" status, from the authz-v3 url. So, we report error that we are not able the validate the domain, because of that we don't find dns-01 challenge.
This behavior is not the same as before. I believe it was changed by the letsencrypt CA.
2020-01-27 23:07:10 +08:00
neilpang f716f6060e minor check update hash for branch name 2020-01-27 23:02:09 +08:00
neilpang 05aa26e619 minor, remove space key 2020-01-27 21:22:42 +08:00
xpac1985 b6552aff75
Added maximum account key length to --help output 2020-01-22 21:21:38 +01:00
xpac1985 3c98fae4f2
Updated/fixed some entries in --help output 2020-01-22 20:00:04 +01:00
neilpang baff032e3b Merge branch 'up' into dev 2020-01-15 22:05:37 +08:00
neilpang 26309f51e3 start 2.8.5 2020-01-15 22:04:49 +08:00
neilpang f8f53a6bd9 debug 2020-01-15 22:01:34 +08:00
neilpang ac3667c765 fix https://github.com/Neilpang/acme.sh/issues/2693 2020-01-15 21:43:49 +08:00
neil 0712e98904 fix https://github.com/Neilpang/acme.sh/pull/2559 2020-01-12 13:36:24 +08:00
neilpang 7a3c61b744 check upgrade hash
https://github.com/Neilpang/acme.sh/issues/2667
2020-01-03 21:38:47 +08:00
neil f59f484c01
Merge pull request #2657 from gildea/master
Return failure when falling through limiting loop
2020-01-01 18:28:30 +08:00
gildea a44ea0ddf0
Return failure when falling through limiting loop
In _send_signed_request and _check_dns_entries, return 1 when the
timeout (or number of retries) has been exhausted.  This allows
the calling function to correctly handle the error.
2019-12-31 20:22:08 -08:00
Zbyszek Żółkiewski 5014f83b86
Fix case sensitive detection of domain in the response request 2019-12-06 09:59:35 +01:00
neil aac9f089d9
Merge pull request #2583 from JohnVillalovos/dev
debug_bash_helper: Use eval as busybox systems have problems
2019-11-15 22:23:07 +08:00
John L. Villalovos adce8f52e8 debug_bash_helper: Use eval as busybox systems have problems
In _debug_bash_helper use eval as we are seeing issues with busybox
systems having issues with array access. Even though they aren't
actually running the code they appear to be parsing it and failing.

Also older versions of busybox have a bug with eval and double quotes,
so make sure to use single quotes when using eval.

Resolves: #2579
2019-11-13 14:30:19 -08:00
arlecchino 867ec010ab
Fix callhook error in manual mode
Fixes #1586  
Check force manual switch before causing error about it.
2019-11-12 19:58:36 +01:00
neil eb6238781d
Merge pull request #2546 from JohnVillalovos/master
Improve debug capabilities when using bash
2019-11-03 19:41:51 +08:00
neilpang 5698bec621 fix https://github.com/Neilpang/acme.sh/issues/2566 2019-11-02 09:48:41 +08:00
neilpang 671edc33e1 fix background color 2019-10-27 11:43:40 +08:00
John L. Villalovos bba5376a36 Improve debug capabilities when using bash
When calling the _debug3() function will print the filename, function
name, and line number when running under bash
2019-10-26 09:07:22 -07:00
neilpang d04c6dd3ac fix https://github.com/Neilpang/acme.sh/issues/2557 and https://github.com/Neilpang/acme.sh/issues/2544 2019-10-25 22:31:36 +08:00
Peter Dave Hello ac9f6e3a41 Remove trailing spaces in text files
This issue in the shell scripts will also be detected in the stable
version of shfmt(we are currently using an ancient pre-release of shfmt)
2019-10-05 21:09:24 +08:00
neilpang 1e7534b9d7 fix https://github.com/Neilpang/acme.sh/issues/2518#issuecomment-538474232 2019-10-05 11:59:04 +08:00
neil 477a04760c
support google public dns (#2522)
* support google dns

* let's start 2.8.4
2019-10-03 21:00:30 +08:00
neilpang b4a62bfa30 let's start 2.8.4 2019-10-03 20:51:06 +08:00
neilpang 10eec7d48c support google dns 2019-10-03 20:37:46 +08:00
neilpang be0df07dfb fix list() performance
https://github.com/Neilpang/acme.sh/issues/2296
2019-09-28 10:54:31 +08:00
neilpang 1ba4ab2bd1 fix https://github.com/Neilpang/acme.sh/issues/2503 2019-09-24 22:10:36 +08:00
neilpang 51b4a9e350 fix HEAD request against the new LE CDN.
wget is fixed
2019-09-24 20:50:24 +08:00
neilpang 5723fd112f fix HEAD request against the new LE CDN.
curl is fixed
2019-09-24 20:00:21 +08:00
neilpang 815a3be48b fix https://github.com/Neilpang/acme.sh/issues/2478
support `sudo -i` and `sudo -s`
2019-09-14 11:21:55 +08:00
neilpang 1081d98bf9 support to specify the nginx or site conf for nginx mode.
https://github.com/Neilpang/acme.sh/issues/2469
2019-09-05 22:05:54 +08:00