From 893917a25dac51a5e0354f8122c5043060ecd573 Mon Sep 17 00:00:00 2001
From: Nils Sandmann <git@softcat.org>
Date: Thu, 22 Mar 2018 11:13:46 +0100
Subject: [PATCH] Fix travis errors

---
 dnsapi/dns_pdns.sh | 18 ++++++------------
 1 file changed, 6 insertions(+), 12 deletions(-)

diff --git a/dnsapi/dns_pdns.sh b/dnsapi/dns_pdns.sh
index 40b344c0..594f9b24 100755
--- a/dnsapi/dns_pdns.sh
+++ b/dnsapi/dns_pdns.sh
@@ -91,14 +91,12 @@ set_record() {
   new_challenge=$3
 
   _pdns_rest "GET" "/api/v1/servers/$PDNS_ServerId/zones/$root"
-  _existing_challenges=($(echo "$response" | _normalizeJson | grep -Po "\"name\":\"$fulldomain\K.*?}]" | grep -Po 'content\":\"\\"\K[^\\]*'))
   _record_string=""
-  _build_record_string $new_challenge
-
-  for i in "${_existing_challenges[@]}"
-    do
-        _record_string+=", "
-        _build_record_string $i
+  _build_record_string "$new_challenge"
+  _existing_challenges=$(echo "$response" | _normalizeJson | grep -Po "\"name\":\"$fulldomain\\K.*?}]" | grep -Po 'content\":\"\\"\K[^\\]*')
+  for oldchallenge in $_existing_challenges; do
+    _record_string="${_record_string}, "
+    _build_record_string "$oldchallenge"
   done
 
   if ! _pdns_rest "PATCH" "/api/v1/servers/$PDNS_ServerId/zones/$root" "{\"rrsets\": [{\"changetype\": \"REPLACE\", \"name\": \"$full.\", \"type\": \"TXT\", \"ttl\": $PDNS_Ttl, \"records\": [$_record_string]}]}"; then
@@ -106,10 +104,6 @@ set_record() {
     return 1
   fi
 
-  if ! notify_slaves "$root"; then
-    return 1
-  fi
-
   return 0
 }
 
@@ -198,5 +192,5 @@ _pdns_rest() {
 }
 
 _build_record_string() {
-  _record_string+="{\"content\": \"\\\"$1\\\"\", \"disabled\": false}"
+  _record_string="${_record_string}{\"content\": \"\\\"$1\\\"\", \"disabled\": false}"
 }